Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Remove deprecated litestar.middleware.exceptions module and deprecated params of internal ExceptionHandlerMiddleware #3435

Merged
merged 6 commits into from
Jun 15, 2024
Merged

feat!: Remove deprecated litestar.middleware.exceptions module and deprecated params of internal ExceptionHandlerMiddleware #3435

merged 6 commits into from
Jun 15, 2024

Conversation

provinzkraut
Copy link
Member

@provinzkraut provinzkraut commented Apr 27, 2024 •
edited
Loading

Description

  • Remove deprecated module litestar.middleware.exceptions
  • Remove deprecated app param of ExceptionHandlerMiddleware
  • Remove deprecated exception_handlers param of ExceptionHandlerMiddleware

Closes

@provinzkraut provinzkraut requested review from a team as code owners April 27, 2024 07:26
@github-actions github-actions bot added area/asgi area/docs This PR involves changes to the documentation area/private-api This PR involves changes to the privatized API Breaking 🔨 size: small type/feat pr/internal labels Apr 27, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (e751d20) to head (e67dcc7).
Report is 165 commits behind head on v3.0.

Additional details and impacted files 
@@            Coverage Diff             @@
##             v3.0    #3435      +/-   ##
==========================================
- Coverage   98.25%   98.24%   -0.01%     
==========================================
  Files         322      323       +1     
  Lines       14672    14455     -217     
  Branches     2332     2295      -37     
==========================================
- Hits        14416    14202     -214     
- Misses        117      118       +1     
+ Partials      139      135       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@provinzkraut provinzkraut force-pushed the remove-exception-handler-middleware-debug-param branch from dd8c727 to 5c13610 Compare May 19, 2024 14:00
@provinzkraut provinzkraut force-pushed the v3.0 branch 2 times, most recently from 4dc78a8 to 81a323f Compare May 26, 2024 07:39
@provinzkraut provinzkraut force-pushed the remove-exception-handler-middleware-debug-param branch from 1882376 to ea2545c Compare June 15, 2024 10:43
@provinzkraut provinzkraut force-pushed the remove-exception-handler-middleware-debug-param branch from 4dbe8c6 to e67dcc7 Compare June 15, 2024 15:27
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8 New Code Smells (required ≤ 3)
7 New Major Issues (required ≤ 2)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-actions GitHub Actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3435

Alc-Alc
Alc-Alc approved these changes Jun 15, 2024
View reviewed changes
Copy link
Contributor

@Alc-Alc Alc-Alc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even @JacobCoffee is not this slow in reviewing

@provinzkraut provinzkraut merged commit 42bf08f into v3.0 Jun 15, 2024
25 of 26 checks passed
@provinzkraut provinzkraut deleted the remove-exception-handler-middleware-debug-param branch June 15, 2024 17:02
provinzkraut added a commit that referenced this pull request Jun 16, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
981ea94 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Jun 21, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
20c0062 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Jul 21, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
01bc44b 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Aug 25, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
d176fe8 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Aug 27, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
37895ee 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Aug 28, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
dc378e7 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Sep 8, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
1f1535c 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Sep 14, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
27d6f50 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Sep 14, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
6ef77c9 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Sep 14, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
71ac0f6 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Sep 15, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
1ca5c49 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Sep 15, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
1a85171 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Sep 21, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
b194a85 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Sep 23, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
adb0924 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Nov 24, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
ee5048d 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Nov 24, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
52165e3 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Nov 28, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
ec91b60 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Nov 29, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
c0793e7 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Dec 12, 2024
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
fcfbdde 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alc-Alc Alc-Alc Alc-Alc approved these changes

@JacobCoffee JacobCoffee Awaiting requested review from JacobCoffee

Assignees
No one assigned
Labels
area/asgi area/docs This PR involves changes to the documentation area/private-api This PR involves changes to the privatized API Breaking 🔨 pr/internal size: small type/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@provinzkraut @Alc-Alc