fix: #2368 - before_request handler modifies handler signature #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janek Nouvertné <[email protected]>
JacobCoffee
approved these changes
Sep 30, 2023
cofin
approved these changes
Sep 30, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2368 by removing the modification of return type annotations based on the return type of the
before_requesthandler.This doesn't seem to break anything and I'm fairly certain not doing this is the correct behaviour (certainly less unexpected), still calling out @litestar-org/maintainers @litestar-org/members for some opinions.