-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove references to SQLAlchemyAsyncConfig.create_engine
#2380
docs: remove references to SQLAlchemyAsyncConfig.create_engine
#2380
Conversation
According to the advanced-alchemy docs, |
It existed in the commit prior to the litestar/litestar/contrib/sqlalchemy/plugins/init/config/common.py Lines 174 to 195 in a463aab
|
I agree, |
Yes, I think this is correct. This means we should probably do this over on the |
Wouldn't it be better to just subclass the config and add that method in |
Good point. We re-export things anyway from Litestar, so we might as well just do that. |
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2380 |
Pull Request Checklist
Description
SQLAlchemyAsyncConfig.create_engine
from docs; useSQLAlchemyAsyncConfig.get_engine
in examples instead.Close Issue(s)