Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix AsyncRedis.close() deprecation warning #2371

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 27, 2023

Before:

  /home/runner/work/litestar/litestar/tests/conftest.py:316: DeprecationWarning: Call to deprecated close. (Use aclose() instead) -- Deprecated since version 5.0.0.
    await client.close()

Source: https://github.com/redis/redis-py/blob/cc4bc1a544d1030aec1696baef2861064fa8dd1c/redis/asyncio/client.py#L568-L573

@sobolevn sobolevn requested review from a team as code owners September 27, 2023 08:22
@Alc-Alc
Copy link
Contributor

Alc-Alc commented Sep 27, 2023

@sobolevn should this also be changed?

await client.close()

@sobolevn sobolevn force-pushed the fix-redis-deprecation branch from 6f1aedc to 8242211 Compare September 27, 2023 09:27
@peterschutt peterschutt enabled auto-merge (squash) September 27, 2023 09:49
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@peterschutt peterschutt merged commit 735cc6a into main Sep 27, 2023
16 checks passed
@peterschutt peterschutt deleted the fix-redis-deprecation branch September 27, 2023 09:56
@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants