-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move mypy.ini
to pyproject.toml
#1974
Comments
pydantic also supports |
I believe this will impact vscode users |
How so? Does it not pick up the config within |
I am just recalling something one of our users had - https://discord.com/channels/919193495116337154/919193688775749662/1093564708256219219 I haven't used vscode in quite a while though... so I'm not sure past this |
## Coffee — 04/04/2023 7:35 PM
can we move mypy.ini into pyproject.toml? I can do the work if its okay to do
## chris — 04/06/2023 10:55 AM
Some MyPy IDE extensions don't like this -- just something to be aware of
## provinzkraut — 04/06/2023 10:56 AM
I think they meant extensions for the IDE, not extensions of mypy?
## chris — 04/06/2023 10:57 AM
Correct provinzkraut. Sorry that was unclear
But VSCode's MyPy extension doesn't. Funny enough I had a user interview with them where I asked them to start supporting it. They said they were working on it along with better poetry support.
But I know you guys pretty much all use pycharm. So perhaps not an issue. VSCode users can of course just run from the command line |
Hm, interesting 🤔 Related microsoft/vscode-mypy#37 |
So we can either move all the mypy config into |
For me option 2 would be my suggestion, but thats due to my journey to eradicate 47 files in the root directory 😅 |
Description
Mypy supports
pyproject.toml
for a long time now.There's no need to have special
mypy.ini
, considering that all config is stored inpyproject.toml
URL to code causing the issue
No response
MCVE
No response
Steps to reproduce
No response
Screenshots
No response
Logs
No response
Litestar Version
main
Platform
Funding
The text was updated successfully, but these errors were encountered: