Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings / Keybindings: not able to remove a binding through the GUI #245

Open
thdoan opened this issue May 5, 2023 · 2 comments
Open

Comments

@thdoan
Copy link

thdoan commented May 5, 2023

As demonstrated below, I removed a binding, restarted the program, and the binding is still not removed:

keybinding_del

@jgmdev
Copy link
Member

jgmdev commented May 5, 2023

Nice catch! if my assumption is correct, basically the issue is the binding is set to nil and when serializing the changes to the user_settings.lua file the value is lost, since the value is now nil it is basically interpreted as not set by the user and default value gets restored on next launch.

Possible fix could be setting the binding to string "none" instead of nil and ignoring it at startup.

@thdoan
Copy link
Author

thdoan commented May 5, 2023

I wish I knew how to program Lua so I could submit a PR myself....maybe someday since I always wanted to make a Roblox game ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants