Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS-V2Gov-015: Incorrect Specifications #115

Closed
danielattilasimon opened this issue Dec 25, 2024 · 1 comment · Fixed by #120
Closed

CS-V2Gov-015: Incorrect Specifications #115

danielattilasimon opened this issue Dec 25, 2024 · 1 comment · Fixed by #120

Comments

@danielattilasimon
Copy link
Contributor

danielattilasimon commented Dec 25, 2024

Function claimBribes() includes a note from previous versions of the codebase which is outdated.

Function unregisterInitiative() has an inline comment that is outdated: weeks * 2^16 > u32. Registration epoch for disabled initiatives is now set to type(uint256).max.

Function getInitiativeState() has an incorrect inline comment for Unregister Condition as an initiative is unregistable at 5th epoch that would result in SKIP.

@danielattilasimon
Copy link
Contributor Author

Function claimBribes() includes a note from previous versions of the codebase which is outdated.

We will address this as part of a fix for #117 & #116.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant