Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing wp-env with Lando? #206

Open
defunctl opened this issue Feb 1, 2023 · 2 comments
Open

Replacing wp-env with Lando? #206

defunctl opened this issue Feb 1, 2023 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@defunctl
Copy link
Contributor

defunctl commented Feb 1, 2023

wp-env is pretty limited in customization, and also suffers from permission issues on Linux.

Any thoughts on my replacing it with Lando, or adding Lando as an additional option?

@defunctl defunctl added the question Further information is requested label Feb 1, 2023
@bswatson
Copy link
Contributor

The issue I was having with Lando for the plugin specifically was that I did not want to include any site specific configurations into the plugin. Everything that is in the plugins/wme-sitebuilder directory is (currently) included in the composer package that is pulled in to liquidweb/nexcess-mapps and deployed to every site on the Nexcess platform.

That being said, if we can resolve the issue by adjusting the files that are made available in the composer file, I have no objections to switching to Lando.

@defunctl
Copy link
Contributor Author

defunctl commented Feb 13, 2023

If I'm understanding correctly, that should be easily solvable with a .gitattributes file, using export-ignore for any file/folder anything that shouldn't come down when this is pulled in as a dependency, as GitHub will exclude it when it creates the zip that composer will use to install dependency.

e.g.

# Ignore paths when git creates an archive of this package
/.lando.yml             export-ignore
/.gitattributes         export-ignore
/.gitignore             export-ignore
/.github                export-ignore
/.editorconfig          export-ignore
# etc...etc...

Switching to Lando will take less time, but I've also just got the go ahead to proceed with a PR to fix the Linux permissions in wp-env, which will undoubtedly take longer and may not even get accepted, but would improve the wp-env package. End of the day, even if permissions are fixed on Linux, it is still very limited in other ways.

Your call in terms which option to proceed with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants