Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thoughts on replacing the container with di52? #205

Open
defunctl opened this issue Feb 1, 2023 · 1 comment
Open

Thoughts on replacing the container with di52? #205

defunctl opened this issue Feb 1, 2023 · 1 comment
Assignees
@bswatson
Labels
question Further information is requested

Comments

@defunctl
Copy link
Contributor

defunctl commented Feb 1, 2023

Given it supports the same PHP versions, but supports auto-wiring, this would drastically reduce the number of definitions we need, supports Service Providers out of the box, and is a lot more "Laravely" in syntax.

Additionally, it is used with many other internal products here.

https://github.com/lucatume/di52
@defunctl defunctl added the question Further information is requested label Feb 1, 2023
@bswatson
Copy link
Contributor

I'm good with swapping it out on the v2+ (main) branch, we'll need to also include a transition guide so implementors know how to swap out usages for StoreBuilder.

https://github.com/liquidweb/nexcess-mapps/blob/develop/nexcess-mapps/Integrations/StoreBuilder.php#L128-L131
https://github.com/liquidweb/nexcess-mapps/blob/develop/nexcess-mapps/Integrations/StoreBuilder.php#L149
https://github.com/liquidweb/nexcess-mapps/blob/develop/nexcess-mapps/Integrations/StoreBuilder.php#L407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bswatson bswatson

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bswatson @defunctl