Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8606] newsletter: remove apostrophes in subject #5775

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m4ra
Copy link
Contributor

@m4ra m4ra commented Nov 28, 2024

Describe your changes
Apostrophes in email subject return Unicode Error, they are now removed. Escaping them, didn't work well, as the subject gets sent with weird encoding.

fixes #5767

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@m4ra
Copy link
Contributor Author

m4ra commented Nov 28, 2024

@goapunk a4 could include this fix too here

@goapunk goapunk self-requested a review December 2, 2024 10:12
@goapunk
Copy link
Contributor

goapunk commented Dec 2, 2024

@m4ra Thanks! I've wondered why we suddenly get this error (as we didn't really change anything) and turns out it's a bug in Django 3.2.11 (because of changes in python 3.12, which we recently upgraded to with Ubuntu 24.04), updating to Django 3.2.12 fixes the error. However, using an apostrophe is as you mention still escaped as html which is wrong (but not a new bug). Should we make a new issue for that and get on with the release or fix it, this is a problem for all emails which have user entered subject, not just the newsletter here, so I guess we need to find all emails which have that in a+ and mb.

@m4ra
Copy link
Contributor Author

m4ra commented Dec 2, 2024

@goapunk I leave this PR open then for including other instances of email subjects and remove apostrophes, besides the newsletter. And I remove it from the milestone as it will be fixed by the django update (I guess you mean 4.2.xx) @CarolingerSeilchenspringer what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: encoding error with email subjects
2 participants