Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7864 [mB] redesign comments and replies (Button Behaviour) #5693

Open
mcastro-lqd opened this issue Sep 3, 2024 · 8 comments
Open

#7864 [mB] redesign comments and replies (Button Behaviour) #5693

mcastro-lqd opened this issue Sep 3, 2024 · 8 comments
Labels
Type: UX/UI or design issue related to the design

Comments

@mcastro-lqd
Copy link
Contributor

mcastro-lqd commented Sep 3, 2024

URL: https://meinberlin-design-testing-dev.liqd.net/ideas/2024-01098/
important screensize: mobile? desktop?
device & browser: Safari Version 17.5 (19618.2.12.11.6) / Chrome Version 126.0.6478.127 (Official Build) (arm64)
Comment/Question:
Sorry, I thought that when we use these elements from the StyleGuid they'd already come with the behaviours, but the blue/link type of buttons should have a different behaviour like in the style guide + their InVision recommendation

StyleGuide: https://styleguide.berlin.de/patterns/09-vertical_marketing-page-element-buttons/09-vertical_marketing-page-element-buttons.html
Invision: http://invis.io/8E13E4TUNQX3

If not so clear, there's also this screen from the ConceptBoard link:
Screenshot 2024-09-03 at 08 43 27

Because currently we can't know which comments we liked.

@mcastro-lqd mcastro-lqd changed the title #7864 [mB] redesign comments and replies #7864 [mB] redesign comments and replies (Button Behaviour) Sep 3, 2024
@CarolingerSeilchenspringer CarolingerSeilchenspringer added the Type: UX/UI or design issue related to the design label Sep 12, 2024
@CarolingerSeilchenspringer
Copy link
Contributor

CarolingerSeilchenspringer commented Sep 18, 2024

@mcastro-lqd @MarleyMi @hom3mad3 this is also true for rating (up/down). Not sure if fixing this will fix it everywhere? Also we didn't consider the status "no active phase" and made a story about this: https://taiga.liqd.net/project/liqd-meinberlin/us/561. Probably should be tackled all at once?

@hom3mad3
Copy link
Contributor

hom3mad3 commented Sep 19, 2024

@mcastro-lqd @MarleyMi @hom3mad3 this is also true for rating (up/down). Not sure if fixing this will fix it everywhere? Also we didn't consider the status "no active phase" and made a story about this: https://taiga.liqd.net/project/liqd-meinberlin/us/561. Probably should be tackled all at once?

@CarolingerSeilchenspringer not sure what you mean by tackling it all at once, but if you could add it as an acceptance criteria to the story, i will have a look! thanks :)

@CarolingerSeilchenspringer
Copy link
Contributor

@hom3mad3 the story is about the behaviour during inactive phase. @mcastro-lqd here also meant the behaviour in active phases like hovering and actually rating. If you want to look at both behaviours at once you can leave this for now. I will put on hold.

@CarolingerSeilchenspringer CarolingerSeilchenspringer added the Status: On hold issue or PR paused label Sep 20, 2024
@MarleyMi
Copy link

grafik This is how it should look when inactive. The thing is the story "Inactive Phase buttons" https://taiga.liqd.net/project/liqd-meinberlin/us/561. Needs Design and is not fully ready yet. But the "inactive button gefällt mir/gefällt mir nicht" could be already integrated I think @CarolingerSeilchenspringer? We also have a Design for Voting and Supporting but this needs a aproval from Bo. grafik I am not sure if this clears up the question @hom3mad3.

@hom3mad3
Copy link
Contributor

@MarleyMi thanks!

@CarolingerSeilchenspringer
Copy link
Contributor

@MarleyMi @hom3mad3 this issue is mainly about the hover and active behaviour. So this issue should still be solved as it was part of the story. If easy, also implement the inactive status, but if not, wait for the inactive story to come (which includes more than the like-button).

@CarolingerSeilchenspringer CarolingerSeilchenspringer removed the Status: On hold issue or PR paused label Oct 17, 2024
@MarleyMi
Copy link

We put this story on hold because we will wait for the inactive button story.

@CarolingerSeilchenspringer
Copy link
Contributor

@MarleyMi @hom3mad3 moved this into another milestone so this milestone can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: UX/UI or design issue related to the design
Projects
None yet
Development

No branches or pull requests

4 participants