-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#7864 [mB] redesign comments and replies (Button Behaviour) #5693
Comments
@mcastro-lqd @MarleyMi @hom3mad3 this is also true for rating (up/down). Not sure if fixing this will fix it everywhere? Also we didn't consider the status "no active phase" and made a story about this: https://taiga.liqd.net/project/liqd-meinberlin/us/561. Probably should be tackled all at once? |
@CarolingerSeilchenspringer not sure what you mean by tackling it all at once, but if you could add it as an acceptance criteria to the story, i will have a look! thanks :) |
@hom3mad3 the story is about the behaviour during inactive phase. @mcastro-lqd here also meant the behaviour in active phases like hovering and actually rating. If you want to look at both behaviours at once you can leave this for now. I will put on hold. |
This is how it should look when inactive. The thing is the story "Inactive Phase buttons" https://taiga.liqd.net/project/liqd-meinberlin/us/561. Needs Design and is not fully ready yet. But the "inactive button gefällt mir/gefällt mir nicht" could be already integrated I think @CarolingerSeilchenspringer? We also have a Design for Voting and Supporting but this needs a aproval from Bo. I am not sure if this clears up the question @hom3mad3. |
@MarleyMi thanks! |
We put this story on hold because we will wait for the inactive button story. |
URL: https://meinberlin-design-testing-dev.liqd.net/ideas/2024-01098/
important screensize: mobile? desktop?
device & browser: Safari Version 17.5 (19618.2.12.11.6) / Chrome Version 126.0.6478.127 (Official Build) (arm64)
Comment/Question:
Sorry, I thought that when we use these elements from the StyleGuid they'd already come with the behaviours, but the blue/link type of buttons should have a different behaviour like in the style guide + their InVision recommendation
StyleGuide: https://styleguide.berlin.de/patterns/09-vertical_marketing-page-element-buttons/09-vertical_marketing-page-element-buttons.html
Invision: http://invis.io/8E13E4TUNQX3
If not so clear, there's also this screen from the ConceptBoard link:
Because currently we can't know which comments we liked.
The text was updated successfully, but these errors were encountered: