Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tests #46

Draft
wants to merge 60 commits into
base: master
Choose a base branch
from
Draft

Feat/tests #46

wants to merge 60 commits into from

Conversation

dorianim
Copy link
Member

@dorianim dorianim commented Apr 8, 2022

This PR adds some unittests. They are meant to test the intended functionality of the code but do not test it in a real scenario, only by using mocks (otherwise it would be integration tests).

Codecov:


Fixes #36

Needs to be tested:

  • computer
  • environment
  • fileHelper
  • gpo
  • hooks
  • imageHelper
  • keytab
  • ldapHelper
  • localUserHelper
  • logging
  • printers
  • realm
  • setup
  • shares
  • templates
  • user

Not tested for now:

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2022

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@dorianim dorianim mentioned this pull request Apr 9, 2022
2 tasks
@codeclimate
Copy link

codeclimate bot commented Apr 9, 2022

Code Climate has analyzed commit cf60b95 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@dorianim dorianim added the technical dept Technichal dept label Sep 15, 2022
@dorianim dorianim self-assigned this Sep 15, 2022
@dorianim dorianim added this to the 1.0.9 milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical dept Technichal dept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write unit tests
2 participants