Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Change umask of homedir to 077 #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

dorianim
Copy link
Member

This changes the umask of userhomes to 077 (Permissions will be 700 respectively) to prevent other users from accessing their data. The default is 022 which makes it possible for users to access other users data if they know the explicit path.
See:

@kiarn @PLanB2008 do you see any unwanted implications of this?

@dorianim dorianim added enhancement New feature or request needs confirmation Some more information is needed to confirm the root of the problem labels Mar 14, 2022
@codeclimate
Copy link

codeclimate bot commented Mar 14, 2022

Code Climate has analyzed commit 4687547 and detected 0 issues on this pull request.

View more on Code Climate.

@kiarn
Copy link
Member

kiarn commented Mar 20, 2022

Hello,

It's surely a good point, but we must test it and wait on feedback from test users.
Teachers can access the students data via shares, so this change should not have bad consequences.
I will also test it in my environment.

Arnaud

@dorianim dorianim modified the milestones: 1.0.9, 1.0.10 Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs confirmation Some more information is needed to confirm the root of the problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants