Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Always become user we are managing #73

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

mhjacks
Copy link
Contributor

@mhjacks mhjacks commented Dec 9, 2024

Enhancement: Enable changing to other non-root users

Reason: Fix #72

Result:

Issue Tracker Tickets (Jira or BZ if any):

@spetrosi
Copy link
Contributor

spetrosi commented Dec 9, 2024

[citest]

@spetrosi
Copy link
Contributor

spetrosi commented Dec 9, 2024

Could you add a test that reproduces the issue that you had in #72?

@mhjacks
Copy link
Contributor Author

mhjacks commented Dec 9, 2024

I'm not sure how to, to be honest. I think the behavior would show up running test_user_units.yml if connecting as a non-root user, but I believe that depends on parts of the workflow that I can't see (i.e. something behind tft.yaml?)

@richm richm changed the title Always become user we are managing fix: Always become user we are managing Dec 9, 2024
@richm richm merged commit e457939 into linux-system-roles:main Dec 9, 2024
16 checks passed
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@fd9cdc7). Learn more about missing BASE report.

Additional details and impacted files
@@         Coverage Diff          @@
##             main   #73   +/-   ##
====================================
  Coverage        ?     0           
====================================
  Files           ?     0           
  Lines           ?     0           
  Branches        ?     0           
====================================
  Hits            ?     0           
  Misses          ?     0           
  Partials        ?     0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System scope tasks seem to have problems when XDG_RUNTIME_DIR is set
3 participants