tests: simplify distro check in tests_environments.yml #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify a distro check in tests_environments.yml to ease potentially adding more EL distros: - because of the short-circuiting of expressions, all the "or" conditions are run currently only on "CentOS" and "RedHat" - since CentOS Stream is the only "unversioned" EL distro, move its condition as the first after the distro check - drop the name check, leaving only the version check, in any other case (i.e. currently on "RedHat") This makes is possible to support more EL distros in this check, and in case they are versioned all it is needed is to tweak the first condition (i.e. the check for "ansible_distribution not in ..."). There is no behaviour change. Signed-off-by: Pino Toscano <[email protected]>
|
[citest] |
richm
approved these changes
Oct 21, 2024
|
[citest bad] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify a distro check in
tests_environments.ymlto ease potentially adding more EL distros:This makes is possible to support more EL distros in this check, and in case they are versioned all it is needed is to tweak the first condition (i.e. the check for
ansible_distribution not in ...).There is no behaviour change.