feat: support registry_username and registry_password #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richm
requested review from
rhatdan,
baude,
vrothberg and
ikke-t
as code owners
|
[citest] |
richm
force-pushed
the
registry-password
branch
2 times, most recently
from
fd50795 to
e1f1727
Compare
|
[citest] |
vrothberg
approved these changes
Apr 15, 2024
Feature: Add support for specifying registry password globally or on a per-spec basis. Reason: Some registries require authentication for access. Result: Users can use the podman role to manage containers with images in registries which require authentication. QE: There is a new test tests_auth_and_security.yml The password is "podman_password". The logs should *not* contain this string. Signed-off-by: Rich Megginson <[email protected]>
richm
force-pushed
the
registry-password
branch
from
e1f1727 to
448edbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Add support for specifying registry password globally or on
a per-spec basis.
Reason: Some registries require authentication for access.
Result: Users can use the podman role to manage containers with
images in registries which require authentication.
QE: There is a new test tests_auth_and_security.yml
Signed-off-by: Rich Megginson [email protected]