fix: ensure user linger is enabled and disabled correctly #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richm
requested review from
rhatdan,
baude,
vrothberg and
ikke-t
as code owners
richm
force-pushed
the
fix-linger-handling
branch
from
f6b58f6 to
05211c1
Compare
|
[citest] |
richm
force-pushed
the
fix-linger-handling
branch
from
05211c1 to
924d943
Compare
|
[citest] |
3 similar comments
|
[citest] |
|
[citest] |
|
[citest] |
richm
force-pushed
the
fix-linger-handling
branch
from
4cc132a to
19a64bc
Compare
|
[citest] |
1 similar comment
|
[citest] |
richm
force-pushed
the
fix-linger-handling
branch
from
a8d8b06 to
656ffae
Compare
|
[citest] |
Cause: The role was not always enabling user lingering before creating resources, and not always canceling lingering after removing resources. Consequence: The role would give errors if attempting to create a secret or other resource requiring lingering, or would leave lingering enabled after removing resources. Fix: Centralize linger handling and keep track of users which may need linger canceling. Ensure linger is canceled for all users if all of that user's resources are removed and linger is no longer needed. Result: Resources for rootless users are always created properly. Lingering is always canceled when no longer needed. Fix issue with toml.j2 - ensure non-string values are written as non-strings. Fix idempotency issue where you could not clean up twice. Allow testing rootless quadlet on EL8 by configuring settings and kernel parameters and rebooting. Fix several cleanup issues, and dump journal if there are test errors. Construct the __params dict to pass to `podman_secret` to fix the JSON string issue with `data` on both Ansible 2.9 and later. Signed-off-by: Rich Megginson <[email protected]>
richm
force-pushed
the
fix-linger-handling
branch
from
656ffae to
b63c88a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause: The role was not always enabling user lingering before
creating resources, and not always canceling lingering after
removing resources.
Consequence: The role would give errors if attempting to create
a secret or other resource requiring lingering, or would leave
lingering enabled after removing resources.
Fix: Centralize linger handling and keep track of users which
may need linger canceling. Ensure linger is canceled for all
users if all of that user's resources are removed and linger is
no longer needed.
Result: Resources for rootless users are always created properly.
Lingering is always canceled when no longer needed.
Signed-off-by: Rich Megginson [email protected]