fix: make role work on el 8.8 and el 9.2 and podman version less than 4.7.0 #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 4.7.0 Cause: Role was using podman and loginctl features not supported on el 8.8/9.2 and podman versions less than 4.7.0. NetworkName and VolumeName not supported until podman 4.7.0. loginctl -P not supported in el 8.8/9.2. Consequence: The role would give failures when managing el 8.8/9.2 machines. Fix: Do not test with NetworkName and VolumeName when podman version is less than 4.7.0. Use loginctl --value -p instead of -P which will work on all versions. Result: The role can manage el 8.8/9.2 machines. Signed-off-by: Rich Megginson <[email protected]>
richm
requested review from
rhatdan,
baude,
vrothberg and
ikke-t
as code owners
|
[citest] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause: Role was using podman and loginctl features not supported on el 8.8/9.2
and podman versions less than 4.7.0. NetworkName and VolumeName not supported
until podman 4.7.0. loginctl -P not supported in el 8.8/9.2.
Consequence: The role would give failures when managing el 8.8/9.2 machines.
Fix: Do not test with NetworkName and VolumeName when podman version is less
than 4.7.0. Use loginctl --value -p instead of -P which will work on all
versions.
Result: The role can manage el 8.8/9.2 machines.
Signed-off-by: Rich Megginson [email protected]