fix: ignore pod not found errors when removing kube specs #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richm
requested review from
rhatdan,
baude,
vrothberg and
ikke-t
as code owners
Cause: The module uses the `podman kube play --done` command to remove the pod specified by the kube spec, but does not check if the pod has already been removed. That is, it is not idempotent. The command gives an error if the pod is not found. This only happens with podman 4.4.1 on EL8.8 and EL9.2. Consequence: The podman role gives an error that the pod specified by the kube spec cannot be found when removing. Fix: The role ignores the 'pod not found' error when removing a kube spec. Result: The role does not give an error when removing a kube spec. NOTE: This has been fixed in the containers.podman.podman_play module upstream but has not yet been released. https://github.com/containers/ansible-podman-collections/pull/863/files#diff-6672fb7f52e2bec3450c2dd7ed9a4385accd9bab8429ea6eecf4d56447f5a1b8R304 Signed-off-by: Rich Megginson <[email protected]>
richm
force-pushed
the
debug-z-stream-failures
branch
from
5744ebc to
b16adcb
Compare
|
[citest] |
spetrosi
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause: The module uses the
podman kube play --donecommand to removethe pod specified by the kube spec, but does not check if the pod has
already been removed. That is, it is not idempotent. The command
gives an error if the pod is not found. This only happens with
podman 4.4.1 on EL8.8 and EL9.2.
Consequence: The podman role gives an error that the pod specified
by the kube spec cannot be found when removing.
Fix: The role ignores the 'pod not found' error when removing
a kube spec.
Result: The role does not give an error when removing a kube
spec.
NOTE: This has been fixed in the containers.podman.podman_play
module upstream but has not yet been released.
https://github.com/containers/ansible-podman-collections/pull/863/files#diff-6672fb7f52e2bec3450c2dd7ed9a4385accd9bab8429ea6eecf4d56447f5a1b8R304
Signed-off-by: Rich Megginson [email protected]