Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example how to run/use the role #238

Open
tyll opened this issue May 28, 2020 · 6 comments
Open

add example how to run/use the role #238

tyll opened this issue May 28, 2020 · 6 comments
Labels
doc affects documentation good first issue help wanted Possible issue for newcomers low effort estimated to require a low effort low impact estimated to make a low impact

Comments

@tyll
Copy link
Member

tyll commented May 28, 2020

The README is missing some basic information about how to install/use the role. It should probably mention how to use ansible-galaxy, what is needed to run from GIT and how to invoke the examples with ansible-playbook.

@tyll tyll added help wanted Possible issue for newcomers low effort estimated to require a low effort low impact estimated to make a low impact doc affects documentation labels May 28, 2020
@pcahyna
Copy link
Member

pcahyna commented May 28, 2020

The role READMEs are currently more a reference documentation, making sure every option is properly described. They are not suitable as task-oriented HOWTOs / user stories. They could be expanded to cover this as well, but since they are already long enough, I believe this is better covered in a separate document, which would also include this basic information you are asking for. We have been working on this with @t-woerner.

@pcahyna
Copy link
Member

pcahyna commented May 28, 2020

The advantage of a separate document would be also that it can be in another format than Markdown (like asciidoc).

@a-mere-peasant
Copy link
Contributor

The information about how to install and invoke an example using ansible-playbook is already given at https://linux-system-roles.github.io/ ,
Wouldn't it be better to build on that since it will be common for all roles ?

@tyll
Copy link
Member Author

tyll commented Jun 16, 2020

The information about how to install and invoke an example using ansible-playbook is already given at linux-system-roles.github.io ,
Wouldn't it be better to build on that since it will be common for all roles ?

Good observation. A link to this documentation from the network role's README might be good and then the other documentation could be extended.

@richm
Copy link
Contributor

richm commented Jun 16, 2020

The information about how to install and invoke an example using ansible-playbook is already given at linux-system-roles.github.io ,
Wouldn't it be better to build on that since it will be common for all roles ?

Good observation. A link to this documentation from the network role's README might be good and then the other documentation could be extended.

+1 - please feel free to submit a PR to https://github.com/linux-system-roles/linux-system-roles.github.io/

@a-mere-peasant
Copy link
Contributor

I think it will be better to restructure the site first .

The contributing and How to install section have their own sub pages and the corresponding sections be removed from the landing page .

Since we already have a detailed contributing I think putting that up at the site should be better as well since that is also common for all the roles .

We can remove anything that might be specific to a single role(this can remain in the role's contributing document) and keep the rest on the site

or

We can specify/mention if something applies to only a single role (currently I only see code structure in this category ) and then maybe specify this for all roles. This should help in reducing duplicates and provide a place for common resources .

The how to install/use page can then be extended with whatever information is required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affects documentation good first issue help wanted Possible issue for newcomers low effort estimated to require a low effort low impact estimated to make a low impact
Projects
None yet
Development

No branches or pull requests

5 participants