Support specifying mac address without quotation mark

Signed-off-by: Wen Liang <[email protected]>

README.md

@@ -266,7 +266,7 @@ By default, profiles are created with autoconnect enabled.
 The `mac` address is optional and restricts the profile to be usable only on
 devices with the given MAC address. `mac` is only allowed for `type`
 `ethernet` or `infiniband` to match a non-virtual device with the
-profile.
+profile. The value of `mac` address is string and should use with quotation mark.
 
 - For `NetworkManager`, `mac` is the permanent MAC address, `ethernet.mac-address`.
 
@@ -574,7 +574,7 @@ network_connections:
     #persistent_state: present  # default
     type: ethernet
     autoconnect: yes
-    mac: 00:00:5e:00:53:5d
+    mac: "00:00:5e:00:53:5d"
     ip:
       dhcp4: yes
 ```

module_utils/network_lsr/argument_validator.py

@@ -418,6 +418,8 @@ def __init__(self, name, force_len=None, required=False, default_value=None):
         self.force_len = force_len
 
     def _validate_impl(self, value, name):
+        if type(value) == int:
+            value = Util.num_to_mac(value, self.force_len)
         v = ArgValidatorStr._validate_impl(self, value, name)
         try:
             addr = Util.mac_aton(v, self.force_len)

module_utils/network_lsr/utils.py

@@ -267,6 +267,25 @@ def mac_ntoa(mac):
     def mac_norm(mac_str, force_len=None):
         return Util.mac_ntoa(Util.mac_aton(mac_str, force_len))
 
+    @staticmethod
+    def num_to_mac(num, force_len=None):
+        mac = []
+        s_num = num
+        while num:
+            num, mod = divmod(num, 60)
+            if mod < 10:
+                mac.insert(0, "0" + str(mod))
+            else:
+                mac.insert(0, str(mod))
+        mac_addr = ":".join(mac)
+        if force_len is not None:
+            if force_len != len(mac):
+                raise MyError(
+                    "not a valid sexagesimal number '%d' for MAC address: '%s'"
+                    % (s_num, mac_addr)
+                )
+        return mac_addr
+
     @staticmethod
     def boolean(arg):
         if arg is None or isinstance(arg, bool):

tests/unit/test_network_connections.py

@@ -3260,6 +3260,15 @@ def test_set_deprecated_slave_type(self):
             self.assertTrue("port_type" in connection)
             self.assertTrue("slave_type" not in connection)
 
+    def test_mac_address_argvalidator(self):
+        """
+        Test that argvalidator for validating mac address is correctly defined.
+        """
+        validator = network_lsr.argument_validator.ArgValidatorMac("mac")
+        self.assertEqual(
+            validator._validate_impl(41135085296, "mac"), "52:54:00:12:34:56"
+        )
+
 
 @my_test_skipIf(nmutil is None, "no support for NM (libnm via pygobject)")
 class TestNM(unittest.TestCase):