Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: openssl is now required for password #227

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

richm
Copy link
Contributor

@richm richm commented Aug 21, 2024

openssl is now used to generate passwords, so make it
a required basic package.

Signed-off-by: Rich Megginson [email protected]

openssl is now used to generate passwords, so make it
a required basic package.

Signed-off-by: Rich Megginson <[email protected]>
@richm richm requested a review from tomjelinek as a code owner August 21, 2024 11:45
@richm
Copy link
Contributor Author

richm commented Aug 21, 2024

@marcelmamula this needs to change on Suse also - not sure if I have the right package name

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.50%. Comparing base (0c318ff) to head (c8e6603).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #227       +/-   ##
===========================================
+ Coverage   50.54%   68.50%   +17.95%     
===========================================
  Files           1        3        +2     
  Lines          91      181       +90     
  Branches       12        0       -12     
===========================================
+ Hits           46      124       +78     
- Misses         45       57       +12     
Flag Coverage Δ
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richm
Copy link
Contributor Author

richm commented Aug 21, 2024

[citest]

@marcelmamula
Copy link
Contributor

@marcelmamula this needs to change on Suse also - not sure if I have the right package name

@richm Package name is correct. LGTM

@richm richm merged commit bc0081f into linux-system-roles:main Aug 21, 2024
27 of 28 checks passed
@richm richm deleted the openssl-required branch August 21, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants