Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix sbd_devices documentation and examples #224

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

tomjelinek
Copy link
Member

Enhancement:
Fix documentation and examples regarding configuring SBD devices in fence_sbd agent.

Reason:
ha_cluster.sbd_devices variable is used in examples even though it isn't defined. In other example the variable is defined, but its content depends on the node the task is executed on, which is bad practice for configuring sbd.

Result:
Examples and documentation are updated to show a recommended way of configuring SBD devices.

Issue Tracker Tickets (Jira or BZ if any):
https://issues.redhat.com/browse/RHELDOCS-18172

@tomjelinek tomjelinek requested a review from richm as a code owner August 20, 2024 11:19
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.50%. Comparing base (06093e4) to head (87a8aa9).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   68.50%   68.50%           
=======================================
  Files           3        3           
  Lines         181      181           
=======================================
  Hits          124      124           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richm richm merged commit 3645f16 into linux-system-roles:main Aug 20, 2024
21 checks passed
@tomjelinek tomjelinek deleted the fix-sbd-doc branch August 20, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants