refactor: [M3-8938] - Update TextField to not depend on ramda
#11306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
mjac0bs and
harsh-akamai
and removed request for
a team
|
Coverage Report: ✅ |
mjac0bs
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Optionally, to be slightly less repetitive, this could be a single changeset ("... in createNodeBalancerConfigSchema and UpdateNodeBalancerConfigSchema") since the same changes were made in both, but two changesets works too.
There was a problem hiding this comment.
Nice, we actually see validation errors now. 🙌🏼
Added some suggestions below to display a more human-readable message when this validation is shown. Currently...
| Header | Header |
|---|---|
Screen.Recording.2024-11-22.at.10.47.04.AM.mov |
  |
Thanks! Co-authored-by: Mariah Jacobs <[email protected]>
jaalah-akamai
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
@bnussman-akamai I think this is a duplicate changeset
jaalah-akamai
added
Approved
Cloud Manager UI test results🎉 455 passing tests on test run #8 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 30m 12s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
455
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
clamputility function in our new@linode/uipackage so that it does not have to rely on ramda 🗑️pnpm- See this pipeline failure 🚫Preview 📷
Note
No UI changes
How to test 🧪
As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅