Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various requested fixes #940

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

Vernholio
Copy link
Collaborator

@Vernholio Vernholio commented May 8, 2024

Fixed

  • Service Transfer Create (POST /account/service-transfers). Included VPC in list of services that a Linode can't use.
  • VPC-related fixes:
    • Corrections to nat_1_1 objects for proper support.
    • Proper IP address formatting for VPC IP addresses.
    • IP Addresses List (GET /linode/instances/{linodeId}/ips). Corrected response example to show VPC's displayed as objects in an array and added ipv4.vpc attribute to x-linode-cli-subtables.
  • Domain Clone (POST /domains/{domainId}/clone). Updated regex examples to proper format.
  • IP Address List (GET /linode/instances/{linodeId}/ips). Replaced requestBody with query string.
  • Object Storage Bucket Contents List (GET /object-storage/buckets/{clusterId}/{bucket}/object-list). Fixed incorrect response sample.
  • Parent/Child Account fixes for pagination and missing warning message.

@zliang-akamai
Copy link
Member

zliang-akamai commented May 9, 2024

Since IPAddressesVPCListResponse no longer represents the actual list API response and is now being a VPC IP object, can we consider rename it? How does IPAddressVPC sound?

Otherwise looks good to me. Thank you so much for fixing the issues in the doc!

CC: @lgarber-akamai

Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vernholio Vernholio merged commit c3a5b98 into linode:development May 14, 2024
1 check passed
Vernholio added a commit that referenced this pull request May 14, 2024
Vernholio added a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants