Fix for duplicate writing in test mode (#428)

linkedin · Sep 17, 2024 · 90206c8 · 90206c8
1 parent af0995a
commit 90206c8
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/dao-impl/ebean-dao/src/main/java/com/linkedin/metadata/dao/EbeanLocalDAO.java b/dao-impl/ebean-dao/src/main/java/com/linkedin/metadata/dao/EbeanLocalDAO.java
@@ -863,8 +863,12 @@ protected <ASPECT extends RecordTemplate> void insert(@Nonnull URN urn, @Nullabl
       _localAccess.add(urn, (ASPECT) value, aspectClass, auditStamp, trackingContext, isTestMode);
     }
 
-    if (_changeLogEnabled) {
-      // skip appending change log table (metadata_aspect) if not enabled
+    // DO append change log table (metadata_aspect) if:
+    //   1. explicitly enabled
+    //   AND
+    //   2. if NOT in test mode
+    //      -> which is ALWAYS a dual-write operation (meaning this insertion will already happen in the "other" write)
+    if (_changeLogEnabled && !isTestMode) {
       _server.insert(aspect);
     }
   }