Upgrade to Express 4

[jayharris]

Any objections to upgrading to Express 4? I've been working on a revised server component that includes WebSocket Proxy support, but it's built on Express 4.

[searls]

I'm +1. Why not?

On Fri, May 9, 2014 at 10:53 PM, Jay Harris [email protected]
wrote:

Any objections to upgrading to Express 4? I've been working on a revised server component that includes WebSocket Proxy support, but it's built on Express 4.

Reply to this email directly or view it on GitHub:
#261

[jayharris]

So far, I haven't seen any disadvantages. There'll be a few more libraries included, but only because Express broke out the extras (like errorhandler and body-parser) into separate libs instead of core. Also, there will be some rework to the Server plugin, but that will be modified anyway to bring in Socket Proxy support.

It should not break any existing Server.coffee configurations (unless you are doing something crazy in your setup).

My biggest concern is with Testem, since that is still using Express 3.

[jayharris]

When upgrading to Express 4, be mindful of #148, #231, and #239.

[searls]

Do you have a PR open for all this express/server/sockets work yet?

[jayharris]

I spent a good portion of time Monday and yesterday on Sockets (#239). I want to make sure that one is solid before Express 4, since I think the change from http-proxy v0.10 to v1.0 requires more diligence and testing than the express v4 changes. I also want to do them separately, since I want to have Sockets available even if Express 4 doesn't work out, yet.

My goal is Sockets today, Express tomorrow.

[Foxandxss]

+10 for me. That would be lovely :)

[ingesolvoll]

Websocket support would be awesome. We started using websockets recently and the lack of proxy support in lineman instantly became a major obstacle. Really made us see the value of server proxying :)

[tandrewnichols]

Will this upgrade fix this output that I see when lineman runs?

connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0
connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0
connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0
connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0
connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0
connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0
connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0
connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0
connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0
connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0
connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0
connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0
connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0
connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0

If not, I'll open a separate issue for that.

[jayharris]

Yes, it will.

[jandudulski]

Hey, what's the status here? @jayharris

[davemo]

Ping @jayharris, did you ever try this out in a local development branch?

[jayharris]

I need to catch up with @jasonkarns about this. I have this functional, except for Push and for Partial Proxy.

[paprende]

Is this anywhere near completion?