Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create entrypoint if it exists as js #11

Closed
jasonkarns opened this issue Mar 1, 2014 · 4 comments
Closed

Don't create entrypoint if it exists as js #11

jasonkarns opened this issue Mar 1, 2014 · 4 comments

Comments

@jasonkarns
Copy link
Member

No description provided.

@jasonkarns
Copy link
Member Author

b5a11ae

@searls
Copy link
Member

searls commented Mar 1, 2014

Not just that it should be looking at files.browserify.entrypoint. If the user changes it later and then installs a new version it's not enough to check coffee or JS.

On Sat, Mar 1, 2014 at 12:19 PM, Jason Karns [email protected]
wrote:


Reply to this email directly or view it on GitHub:
#11

@jasonkarns
Copy link
Member Author

Yeah, this is just a half step. To avoid the general rename case we have two options that I see.

  1. don't run this script at install time (perhaps by tying it into the lineman install subcommand lineman install lineman#218)
  2. pulling the config value from lineman itself. which doesn't really make sense during the first install because lineman may not even be available at that point.

Does npm fire off the postinstall scripts as each package is installed? Or queue them up and fire them off after the entire install is finished?

@searls
Copy link
Member

searls commented Mar 1, 2014

I think lineman will always be available at install time. As a peer dep, npm will ensure it's there first.

On Sat, Mar 1, 2014 at 12:32 PM, Jason Karns [email protected]
wrote:

Yeah, this is just a half step. To avoid the general rename case:

  1. don't run this script at install time (perhaps by tying it into the lineman install subcommand lineman install lineman#218)
  2. pulling the config value from lineman itself. which doesn't really make sense during the first install because lineman may not even be available at that point.

Does npm fire off the postinstall scripts as each package is installed? Or queue them up and fire them off after the entire install is finished?

Reply to this email directly or view it on GitHub:
#11 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants