Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is a modal? #2308

Open
CryZe opened this issue Dec 16, 2022 · 3 comments
Open

What is a modal? #2308

CryZe opened this issue Dec 16, 2022 · 3 comments
Labels
question causes uncertainty

Comments

@CryZe
Copy link
Contributor

CryZe commented Dec 16, 2022

It seems like recent changes turned modals into essentially tooltips on at least Windows. I don't believe this was intended (unfocusable, no window borders), but maybe it's just not clear what a modal even is supposed to be.

@jneem
Copy link
Collaborator

jneem commented Dec 16, 2022

By "modal" do you mean windows created with WindowLevel::Modal? If so, bear in mind that WindowLevel is only about the z-order, and doesn't (or at least, shouldn't according to the docs) affect borders or focus or anything else.

There was some discussion on #2042 about the cross-platform API and how it should map onto windows, but it's quite possible that we got something wrong.

@CryZe
Copy link
Contributor Author

CryZe commented Dec 16, 2022

Well it totally does on Windows. The code on master currently treats it 100% like a tooltip and makes it unfocusable, unclickable, unmovable and removes all decorations.

@xStrom
Copy link
Member

xStrom commented Dec 17, 2022

I was looking into some of this code recently and couldn't find any implementation beyond tooltips. So I was left with the impression that it isn't implemented, or at least isn't tested.

Maybe I missed something though. Do we have an example in Druid that shows modals in action?

@xStrom xStrom added the question causes uncertainty label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question causes uncertainty
Projects
None yet
Development

No branches or pull requests

3 participants