-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide CentralDogmaPropertySupplier that can read YAML #173
Comments
related: line/centraldogma#151 |
I've thought about this and come up with two workarounds. I'm not sure if anyone is following the issue, but let me share them: (1) Implement a PropertySupplier that supports YAML probably we? can submit PR with this approach to this repository...? (2) Support YAML/JSON5 to JSON conversion in user land with CI or scripts (Example) # See wiki.example.com at first!
decaton.partition.concurrency: 1 # All tasks are processed after calling deferCompletion
decaton.processing.rate.per.partition: -1
decaton.max.pending.records: 2000 # message is not small, this is to avoid OOME. Do not consume many messages
decaton.group.rebalance.timeout.ms: 5000
decaton.processing.shutdown.timeout.ms: 5000 # must be same as above
decaton.ignore.keys:
- "user-1" # abuser
- "user-2" # QA
↓ {
"decaton.partition.concurrency": 1,
"decaton.processing.rate.per.partition": -1,
"decaton.max.pending.records": 2000,
"decaton.group.rebalance.timeout.ms": 5000,
"decaton.processing.shutdown.timeout.ms": 5000,
"decaton.ignore.keys": [
"user-1",
"user-2"
]
} (this assumes that user app with decaton reads I hope this is helpful. It seems the use of Central Dogma in decaton is very simple. Even without using Central Dogma's JSON support, decaton can achieve this issue by receiving the file as a text file and using an object mapper to interpret it as JSON or YAML (probably). I hope this! |
The properties files on centraldogma must be written in JSON format for now.
I want to leave some comments on the properties files, but JSON doesn't support comment-out.
So, I hope that decaton-centraldogma supports YAML which supports comment-out.
The text was updated successfully, but these errors were encountered: