Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully stop the mirror scheduling job when a server stops #1074

Open
ikhoon opened this issue Dec 20, 2024 · 0 comments
Open

Gracefully stop the mirror scheduling job when a server stops #1074

ikhoon opened this issue Dec 20, 2024 · 0 comments
Labels
Milestone

Comments

@ikhoon
Copy link
Contributor

ikhoon commented Dec 20, 2024

If a mirror job is stopped while performing Git operations, the data of Git is broken and the next fetch fails with the following error.

com.linecorp.centraldogma.server.mirror.git.GitMirrorException: 
  Failed to fetch the remote repository 'xxxx/yyy.git' to the local repository '/'. 
  (reason: Expected ACK/NAK, got: shallow fb187e8ccee78bddad8f026f6fcee4be8eed614a
	at com.linecorp.centraldogma.server.internal.mirror.AbstractGitMirror.mirrorRemoteToLocal(AbstractGitMirror.java:274)
	at com.linecorp.centraldogma.server.internal.mirror.SshGitMirror.mirrorRemoteToLocal(SshGitMirror.java:119)
	at com.linecorp.centraldogma.server.internal.mirror.AbstractMirror.mirror(AbstractMirror.java:185)
	at com.linecorp.centraldogma.server.internal.mirror.InstrumentedMirroringJob.lambda$run$0(InstrumentedMirroringJob.java:66)
	at io.micrometer.core.instrument.composite.CompositeTimer.record(CompositeTimer.java:69)
	at com.linecorp.centraldogma.server.internal.mirror.InstrumentedMirroringJob.run(InstrumentedMirroringJob.java:65)
	at com.linecorp.centraldogma.server.internal.mirror.MirrorSchedulingService.run(MirrorSchedulingService.java:252)
	at com.linecorp.centraldogma.server.internal.mirror.MirrorSchedulingService.lambda$runAsync$5(MirrorSchedulingService.java:244)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:131)
	at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:76
@ikhoon ikhoon added the defect label Dec 20, 2024
@ikhoon ikhoon added this to the 0.73.0 milestone Dec 20, 2024
@minwoox minwoox modified the milestones: 0.73.0, 0.74.0 Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants