Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right-to-left languages seem to be unhandled #28

Open
sixtyfive opened this issue Sep 27, 2018 · 4 comments
Open

Right-to-left languages seem to be unhandled #28

sixtyfive opened this issue Sep 27, 2018 · 4 comments

Comments

@sixtyfive
Copy link

When trying to write RTL languages such as Arabic or Aramaic (the two I happen to be working with regularly, didn't try an unconnected one like Hebraic), it looks like this:

image

The expected result would be like what e.g. gxi displays:

image

Note that in the second screenshot, some will argue that the RTL languages should not be aligned to the left edge of the window. I disagree partly. That's good behaviour for documents that are RTL only but mostly, in a text editor, one will be working with LTR/RTL-mixed documents, where it's much less confusing to have a main direction, so the above is actually really nice and shows that xi-core itself doesn't seem to have a problem with it.

@sixtyfive
Copy link
Author

(Minor additional point: I've never seen anything that automatically adjusts font size to make the different scripts look the same size relative to each other, but it's worth mentioning. Arabic is usually too small, although here it looks a little too big in both examples. Aramaic is too small in both, as compared to the latin script reference text.)

@linde12
Copy link
Owner

linde12 commented Sep 27, 2018

Cool! Nice find, i have actually never tried. This should definitely be supported, but when would depend on the implementation cost/willingness of contributor. Maybe we could have a look at gxi and see how it's being done there.

@sixtyfive
Copy link
Author

I don't know Go (or Rust) but I'll be watching the issue in case there's questions about what looks right or what doesn't :)

@linde12
Copy link
Owner

linde12 commented Oct 9, 2018

I think this should be solved if we "just" draw the unicode characters correctly. At the moment kod doesnt support fullwidth chars or unicode modifier chars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants