Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about jupyter-nb-clear-output pre-commit hook when running .initialize_new_project.sh #493

Closed
drewoldag opened this issue Oct 18, 2024 · 1 comment · Fixed by #498
Assignees

Comments

@drewoldag
Copy link
Collaborator

Just created a new project with python 3.11, got the following warning when running .initialize_new_project.sh:

[WARNING] hook id `jupyter-nb-clear-output` uses deprecated stage names (commit) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
@drewoldag drewoldag self-assigned this Oct 28, 2024
@drewoldag
Copy link
Collaborator Author

drewoldag commented Oct 28, 2024

I believe that the pre-commit documentation is indicating that we simply need to change the term "commit" to "pre-commit".
https://pre-commit.com/#confining-hooks-to-run-at-certain-stages
https://pre-commit.com/#supported-git-hooks

Specifically this line:

new in 3.2.0: The values of stages match the hook names. Previously, commit, push, and merge-commit matched pre-commit, pre-push, and pre-merge-commit respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant