Unicode Compiler Error Fix #214
Conversation
Signed-off-by: Gene Walters <[email protected]>
Signed-off-by: Gene Walters <[email protected]>
| HANDLE hFile = | ||
| CreateFile(filepath.c_str(), GENERIC_READ, FILE_SHARE_READ, nullptr, | ||
| CreateFile(tFilepath.c_str(), GENERIC_READ, FILE_SHARE_READ, nullptr, |
There was a problem hiding this comment.
Instead of possibly converting the filename to a char or wide character, why no use CreateFileA directly so it always uses char? CreateFile is really a macro that switches between CreateFileA and CreateFileW based on the unicode switch anyways
|
Personally I don't like TCHAR approach. Filename in USD is usually UTF8, so we can assume input string(in Please take a look at a code fragment in TinyEXR: https://github.com/syoyo/tinyexr/blob/5fcb4dcb6e3abf96214b67e5c54db1ceec6a455c/tinyexr.h#L6746 The same implementation is also used in OpenUSD: PixarAnimationStudios/OpenUSD#1580 |
|
I've fixed the issue in another branch. It always uses It also provides I'll merge |
|
Beautiful! Sorry I was pulled away from this for a while, but @syoyo fixed it! |
Using TCHAR string to fix compiler error when compiling with UNICODE
TCHAR automatically resolves to wchar or char depending if unicode is enabled or not.
Resolves #213