-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoloop V2 Features #319
Comments
Taking this a step further, I would love to be able to set a default rule for all channels as in general, I want the same autoloop rules for all of my channels. In my case my desire is just to acquire more inbound liquidity.
This would be awesome - I'd love to be able to batch loop operations across multiple channels / peers at once to save fees. In addition, I'd love to just be able to set percentage fee limits rather than raw satoshis. If my node is doing a 2x larger loop, I'm okay with paying 2x more in fees. Normally the limits of what I'm willing to pay is percentage based. |
Wouldn't making loop scriptable be a better approach? Anyway, things that probably can't be done in scripts without direct support:
|
Thanks for the feedback @Kixunil!
Uncertain by what you mean here? Just a note that a lot of your suggestions here aren't specifically tied to autoloop, so probably deserve their own issue on the loop repo if they are features that are important to you! Commented on a few here that I think are relevant.
Good news is that autoloop already covers this! You can set a
Further good news is that this is already the case, and something that we have on the cards (referred to as batching in the top level issue). When you perform a swap, you can advertise a cutoff time by which you want the on chain htlc to be published. If the swap server has multiple swaps that hit a similar deadline, they will all go in one tx. We're looking into taking this further with autoloop, and having the loop server advertise specific batch times so that all the autoloopers running can pick a batch time and get better privacy and fees.
For loop in, you can set the client to externally provide the on-chain htlc, so as is it is possible for a client to pay on chain and the loop server to pay btcpay off-chain. However, there is some complexity there. The btcpay node needs to be reachable by the loop server off-chain, otherwise it can't make the payment to the merchant. If loop can't pay the merchant, it will never sweep the on-chain htlc, and then the person paying the on-chain htlc will need to sweep the timeout path, which has a large delay, and requires additional action from a client paying a merchant. Theoretically possible, but would not recommend at present (lots of edge cases to work out). Would recommend opening an issue for this one if possible.
Since you can create the loop in htlc yourself using
This is out of scope for a swap, I would say, and is likely more complex than it's worth.
You can already provide loop out with whatever payout address you like. Xpub support would indeed be cool, would suggest a feature request issue here if just providing an address is insufficient for your use case. |
Having ability to supply a script (e.g. by running external program that connects to RPC) that can dynamically affect the rules of swapping could allow others to implement various rules as they wish. This is already possible using RPC and such, but I guess there's a room for making it simpler. E.g. have an RPC method Yeah, I guess those features can be implemented with external scripts if the above is available. I wrote my ideas as things I'd love to see implemented somehow and if the solution is creating all building blocks to allow other software to implement these ideas then it's fine.
I would expect the node be the same
Not entirely sure if the logic of picking a UTXO which satisfies the requirements should be in
Providing required APIs to do this externally would be helpful and hopefully not too complex. Maybe it only needs PSBT support. |
About xpub, my general idea is that a mechant wants to keep at least |
I second this! Being able to set a maximum effective fee rate, like balanceofsatoshi's |
There are many directions we could take the autoloop feature in. This issue outlines a few features that could be implemented in upcoming iterations.
Please comment if a specific feature would be helpful for your usecase, or you would like to request a feature that is not listed.
Liquidity Management
Control
The text was updated successfully, but these errors were encountered: