-
Notifications
You must be signed in to change notification settings - Fork 371
Meeting Notes 2021 08 09
Elias Rohrer edited this page Aug 9, 2022
·
1 revision
-
Matt relevant slack msg ("current priorities are"):
- https://github.com/rust-bitcoin/rust-lightning/pull/1038 (should be there today)
- https://github.com/rust-bitcoin/rust-lightning/pull/1035 ( should be there today)
- https://github.com/rust-bitcoin/rust-lightning/pull/1025
- https://github.com/rust-bitcoin/rust-lightning/pull/1019 ( should be there today). after this lands I'll rebase https://github.com/rust-bitcoin/rust-lightning/pull/1011 on it and we'll need to do that
- https://github.com/rust-bitcoin/rust-lightning/pull/1009 needs a few small changes from antoine but we need it asap. I've offered to take it over. after he does that I'll rebase https://github.com/rust-bitcoin/rust-lightning/pull/985 on it
-
Both 985 and 1011 can be reviewed now, but will need minor tweaks in rebase.
-
Matt: "I'd also really hoped to get https://github.com/rust-bitcoin/rust-lightning/pull/1034 in 0.0.100 as overtorment is waiting on it, but with no review on it that's just not gonna happen."
-
Do we want to relax reviewing standards, or stay with 2 per PR?
-
Jeff suggest more frequent releases
-
Matt tends to “mindlessly throw user requests into the next release,” and in this case it resulted in 0.0.100 getting big
-
985 and 1011 are big and def need to go into 0.0.100
-
Matt: we cannot cut anything else out
- Already cut out ChannelClosed event PR
- 1025 we could cut but it’s not that big
- 1025 = gonna have arik + val reviewers
- Not worried about 1038, 1035, or 1019
- 1011 just rebased on 1019, it’s nontrivial but important
- Needs 2 reviewers
- Related to jeff’s recent PR, so jeff + val signed up to review
- 1009 waiting on antoine, it’s largely there
- Matt: 985 gonna want to rebase on 1009, but it is still reviewable on its own
- 985
- Arik + val to review
- 1034: based on 1025, that one’s not gonna happen for 0.0.100 though we need to do it
- Matt + jeff been reviewing
- Tibo still has outstanding comments
- Matt trying to horse trade w/ rusty to exchange spec stuff support. But both got busy last week
- Insanity in DC last week was disruptive
- Miron slack msg: “bug in no-std in rust-secp256k1 (serde broken? nobody uses it?) found by Maxim - https://github.com/rust-bitcoin/rust-secp256k1/pull/314”
- Miron: do we want embedded tests in CI?
- Nothing needed for next release
- Arik: on hold w bindings for some review work.
- Matt: don’t feel super great w/o some stuff tagged 0.0.101. Maybe we should tell them to wait til then
- Exposing the list of in-flight claims, thats gonna be important for them to ship
- Their public beta is on mainnet :(
- No one single way to do it currently
- Rusty to write sth for spec, part of matt’s horse trading (he wanted bolt 12, offers stuff)
- Progress
- Working on maybe embedding rust docs into the site