Vec Broadcaster #3448
Draft
Vec Broadcaster #3448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation of `BroacasterInterface` that does not broadcast transactions immediately, but stores them internally to broadcast later with a call to `release_transactions`.
tnull
reviewed
Dec 9, 2024
| /// is ready. | ||
| pub struct VecBroadcaster { | ||
| channel_id: ChannelId, | ||
| transactions: Mutex<Vec<Transaction>>, |
There was a problem hiding this comment.
As we'll still want to broadcast the individual packages, this might need to be a Vec<Vec<Transaction>>
| } | ||
|
|
||
| /// Used to actually broadcast stored transactions to the network. | ||
| #[instrument(skip_all, fields(channel = %self.channel_id))] |
There was a problem hiding this comment.
I'm not sure we require the instrument statment here?
|
|
||
| impl BroadcasterInterface for VecBroadcaster { | ||
| fn broadcast_transactions(&self, txs: &[&Transaction]) { | ||
| let mut tx_storage = self.transactions.lock(); |
There was a problem hiding this comment.
Suggested change
| let mut tx_storage = self.transactions.lock(); | |
| let mut tx_storage = self.transactions.lock().unwrap(); |
| fn broadcast_transactions(&self, txs: &[&Transaction]) { | ||
| let mut tx_storage = self.transactions.lock(); | ||
| for tx in txs { | ||
| tx_storage.push((*tx).to_owned()) |
There was a problem hiding this comment.
I think we might want to see if we can dedup the packages before pushing, i.e., possibly only keep the latest version of a transaction, for example if we'd bump over and over again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of
BroacasterInterfacethat does not broadcast transactions immediately, but stores them internally to broadcast later with a call torelease_transactions.