-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft][Splicing] Partial, perform interactive transaction negotiation for new funding #3444
Draft
optout21
wants to merge
17
commits into
lightningdevkit:main
Choose a base branch
from
optout21:splice-dual-tx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,364
−311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2024
…splice_ack messages, but fail afterwards
…nd OutboundV2Channel
…nd OutboundV2Channel
optout21
force-pushed
the
splice-dual-tx
branch
from
December 11, 2024 20:33
fb4bd94
to
6a06f1e
Compare
Rebased to current main, and current state of #3443 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a next step in the splicing partial implementation, including and depending on the following:
Also relevant: #3418
Next step in splicing (#1621): This PR adds the implementation of performing the interactive transaction negotiation for the new post-splice funding transaction, after the
splice_init
&splice_ack
handshake. Only the initiator can currently contribute.The initiator adds the current funding tx as input, plus additional inputs, and the new funding as output plus a change output (if applicable).
After
tx_complete
the flow stops, does not yet follow to the commitment/signature exchange.