Correct return value for apply_post_close_monitor_update
#3426
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change accidentally inverted the returned monitor update for the case where an update is applied after the channel has been closed. This commit corrects that mistake.
TheBlueMatt
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Oof, thanks. Luckily the return value is actually unused (and dropped entirely in #3414).
TheBlueMatt
approved these changes
Nov 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3426 +/- ##
==========================================
- Coverage 89.25% 89.20% -0.06%
==========================================
Files 130 130
Lines 106959 106965 +6
Branches 106959 106965 +6
==========================================
- Hits 95464 95413 -51
- Misses 8706 8753 +47
- Partials 2789 2799 +10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c99d3d7 accidentally inverted the returned monitor update for the case where an update is applied after the channel has been closed. This commit corrects that mistake.