Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt: Run on the routing directory (1/3) #3336

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Sep 24, 2024

This is PR 1/3, just formatting gossip.rs.

Followups: #3337, #3338.

@tnull tnull changed the title rustfmt: Run on the routing directory rustfmt: Run on the routing directory (1/3) Sep 24, 2024
@arik-so
Copy link
Contributor

arik-so commented Sep 24, 2024

router.rs is so absolutely massive, I almost wonder if perhaps we should have a separate PR just for that?

@arik-so
Copy link
Contributor

arik-so commented Sep 24, 2024

although I guess just the commit should do the trick

@tnull tnull force-pushed the 2024-09-rustfmt-router branch from 8a8e6fa to 01e58df Compare September 24, 2024 04:58
@tnull
Copy link
Contributor Author

tnull commented Sep 24, 2024

router.rs is so absolutely massive, I almost wonder if perhaps we should have a separate PR just for that?

Wait for it, I'm in the process of splitting it.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.66%. Comparing base (a0d0f02) to head (f299a48).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3336    +/-   ##
========================================
  Coverage   89.65%   89.66%            
========================================
  Files         126      126            
  Lines      102750   103226   +476     
  Branches   102750   103226   +476     
========================================
+ Hits        92123    92554   +431     
- Misses       7904     7951    +47     
+ Partials     2723     2721     -2     
Flag Coverage Δ
89.66% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valentinewallace
Copy link
Contributor

Landing since I think we can fix things in follow-up if needed.

@valentinewallace valentinewallace merged commit 053281f into lightningdevkit:main Sep 25, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants