Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-ups for PR 3137 #3416

Open
dunxen opened this issue Nov 21, 2024 · 2 comments · May be fixed by #3423
Open

Follow-ups for PR 3137 #3416

dunxen opened this issue Nov 21, 2024 · 2 comments · May be fixed by #3423
Labels
Dual-funding
Milestone
0.2

Comments

@dunxen
Copy link
Contributor

dunxen commented Nov 21, 2024

The following feedback is outstanding for #3137 (hovering over each is a quick way to see what the comment is about):
@dunxen dunxen added this to the 0.1 milestone Nov 21, 2024
This was referenced Nov 21, 2024
Open
Open
@TheBlueMatt
Copy link
Collaborator

We're gonna walk back our v2 enablement for 0.1, so this needs to happen for 0.2.

@TheBlueMatt TheBlueMatt modified the milestones: 0.1, 0.2 Dec 12, 2024
@dunxen
Copy link
Contributor Author

dunxen commented Dec 12, 2024

We're gonna walk back our v2 enablement for 0.1, so this needs to happen for 0.2.

I'll have those cfg flags re-added this week still. Just travelling home today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dual-funding
Projects
None yet
Milestone
0.2
Development

Successfully merging a pull request may close this issue.

Follow-ups to PR 3137 dunxen/rust-lightning
2 participants
@TheBlueMatt @dunxen