Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings #10

Open
d6y opened this issue Oct 9, 2017 · 0 comments
Open

Fix compiler warnings #10

d6y opened this issue Oct 9, 2017 · 0 comments

Comments

@d6y
Copy link
Member

d6y commented Oct 9, 2017

sbt compile produces many warnings. We should fix them up.

[info]   Compilation completed in 10.242 s
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:235: Octal escape literals are deprecated, use \u001a instead.
[warn]     private def chrExcept(cs: Char*): Parser[Char] = elem("", {c => ('\032' :: cs.toList) forall (_ != c)}) //{x =>  !cs.contains(x)})
[warn]                                                                       ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:469: non-variable type argument net.liftmodules.textile.TextileParser.Textile in type pattern List[net.liftmodules.textile.TextileParser.Textile] (the underlying of List[net.liftmodules.textile.TextileParser.Textile]) is unchecked since it is eliminated by erasure
[warn]       case attrs ~ (elms: List[Textile]) => Pre(reduceCharBlocks(elms), attrs)
[warn]                           ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:901: non-variable type argument String in type pattern scala.xml.Atom[String] is unchecked since it is eliminated by erasure
[warn]     case Seq(head: Atom[String], tail @ _*) =>
[warn]                    ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:902: non-variable type argument String in type scala.xml.Atom[String] is unchecked since it is eliminated by erasure
[warn]       val (text, rest) = tail span { _.isInstanceOf[Atom[String]] }
[warn]                                                    ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:414: match may not be exhaustive.
[warn] It would fail on the following input: ~(_, (x: net.liftmodules.textile.TextileParser.Textile forSome x not in net.liftmodules.textile.TextileParser.Anchor))
[warn]     lazy val a_ref: Parser[Textile] = ('[' ~> urlStr <~ ']') ~ url <~ endOfLine ^^ {case  fr ~ (url: Anchor) => ARef(fr, url.href) }
[warn]                                                                                    ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:467: match may not be exhaustive.
[warn] It would fail on the following input: ~(_, (x: Object forSome x not in (List[?], net.liftmodules.textile.TextileParser.HTML)))
[warn]     closingTag("pre") <~ rep(' ') <~ '\n' ^^ {
[warn]                                              ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:72: type Pair in object Predef is deprecated (since 2.11.0): use built-in tuple syntax or Tuple2 instead
[warn]     def findRefs(in : List[Textile]) : List[Pair[String,String]] = in match {
[warn]                                        ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:73: object Pair in object Predef is deprecated (since 2.11.0): use built-in tuple syntax or Tuple2 instead
[warn]       case (s : ARef) :: rest => {Pair(s.name, s.href) :: findRefs(rest)}
[warn]                                   ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:787: type Pair in object Predef is deprecated (since 2.11.0): use built-in tuple syntax or Tuple2 instead
[warn]     def toList : List[Pair[String, String]] = {
[warn]                  ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:788: type Pair in object Predef is deprecated (since 2.11.0): use built-in tuple syntax or Tuple2 instead
[warn]       var ret : List[Pair[String,String]] = Nil
[warn]                 ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:794: object Pair in object Predef is deprecated (since 2.11.0): use built-in tuple syntax or Tuple2 instead
[warn]         if ((tn ne null) && (tv ne null)) ret = Pair(tn,tv) :: ret
[warn]                                                 ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:856: type Pair in object Predef is deprecated (since 2.11.0): use built-in tuple syntax or Tuple2 instead
[warn]       def toList(st : List[Attribute]) : List[Pair[String, String]] = {
[warn]                                          ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:863: type Pair in object Predef is deprecated (since 2.11.0): use built-in tuple syntax or Tuple2 instead
[warn]       def crunchStyle(st : List[Pair[String, String]]) : List[Pair[String,String]] = {
[warn]                            ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:863: type Pair in object Predef is deprecated (since 2.11.0): use built-in tuple syntax or Tuple2 instead
[warn]       def crunchStyle(st : List[Pair[String, String]]) : List[Pair[String,String]] = {
[warn]                                                          ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:866: type Pair in object Predef is deprecated (since 2.11.0): use built-in tuple syntax or Tuple2 instead
[warn]         (p._1.reduceLeft{(a : Pair[String,String],b : Pair[String,String]) => Pair("style", a._2 + ";"+ b._2)}) :: p._2
[warn]                               ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:866: type Pair in object Predef is deprecated (since 2.11.0): use built-in tuple syntax or Tuple2 instead
[warn]         (p._1.reduceLeft{(a : Pair[String,String],b : Pair[String,String]) => Pair("style", a._2 + ";"+ b._2)}) :: p._2
[warn]                                                       ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:866: object Pair in object Predef is deprecated (since 2.11.0): use built-in tuple syntax or Tuple2 instead
[warn]         (p._1.reduceLeft{(a : Pair[String,String],b : Pair[String,String]) => Pair("style", a._2 + ";"+ b._2)}) :: p._2
[warn]                                                                               ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:869: type Pair in object Predef is deprecated (since 2.11.0): use built-in tuple syntax or Tuple2 instead
[warn]       def fromList(st : List[Pair[String,String]]) : MetaData = {
[warn]                         ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:909: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       XmlElem(null, "p", fromStyle(attrs), TopScope, flattenAndDropLastEOL(elems) : _*) ++ Text("\n")
[warn]       ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:916: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]     XmlElem(null, "acronym", fromStyle(AnyAttribute("title", acro) :: Nil), TopScope, Text(thing) : _*)
[warn]     ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:922: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       val img = XmlElem(null, "img", fromStyle(AnyAttribute("src", url) :: AnyAttribute("alt", alt) :: attrs), TopScope, children : _*)
[warn]                 ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:924: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       if (link ne null) XmlElem(null, "a", fromStyle(AnyAttribute("href", link) :: attrs), TopScope, img : _*)
[warn]                         ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:988: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]     XmlElem(null, "h"+what, fromStyle(attrs), TopScope, super.toHtml : _*) ++
[warn]     ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:994: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       val par : NodeSeq = XmlElem(null, "p", Null, TopScope, flattenAndDropLastEOL(elems) : _*) ++ Text("\n")
[warn]                           ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:995: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       XmlElem(null, "blockquote", fromStyle(attrs), TopScope, par : _*)  ++ Text("\n")
[warn]       ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1003: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       val code = XmlElem(null, "code", attributes, TopScope, contents : _*)
[warn]                  ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1004: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       XmlElem(null, "pre", attributes, TopScope, code : _*) ++ Text("\n")
[warn]       ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1017: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       XmlElem(null, tag, fromStyle(attrs.filter(validHtmlAttr(tag, _))), TopScope, flattenAndDropLastEOL(elems) : _*)
[warn]       ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1023: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       XmlElem(null, "sup", Null, TopScope,
[warn]       ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1024: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]               XmlElem(null, "a", fromStyle(List(AnyAttribute("href", "#fn"+num))), TopScope, Text(num) : _*) : _*)
[warn]               ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1032: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       XmlElem(null, "p", fromStyle(AnyAttribute("id", "fn"+num) :: attrs), TopScope,
[warn]       ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1033: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]               (XmlElem(null, "sup", Null, TopScope, Text(num) : _*) :: flattenAndDropLastEOL(elems)) : _*) ++ Text("\n")
[warn]                ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1042: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]     XmlElem(null, "em", fromStyle(attrs), TopScope, flattenAndDropLastEOL(elems) : _*) ::
[warn]     ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1050: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       XmlElem(null, "strong", fromStyle(attrs), TopScope, flattenAndDropLastEOL(elems) : _*) ::
[warn]       ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1061: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       XmlElem(null, "table", fromStyle(attrs), TopScope, flattenAndDropLastEOL(elems) : _*) ++ Text("\n")
[warn]       ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1067: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       XmlElem(null, "tr", fromStyle(attrs), TopScope, flattenAndDropLastEOL(elems) : _*) ++ Text("\n")
[warn]       ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1073: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       XmlElem(null,
[warn]       ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1083: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       XmlElem(null, if (numbered) "ol" else "ul", fromStyle(Nil), TopScope, flattenAndDropLastEOL(elems) : _*) ++ Text("\n")
[warn]       ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1089: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       XmlElem(null, "li", fromStyle(attrs), TopScope, flattenAndDropLastEOL(elems) : _*) ++ Text("\n")
[warn]       ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1101: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]       XmlElem(null, tag, fromStyle(attrs), TopScope, flattenAndDropLastEOL(elems) : _*) ::
[warn]       ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1110: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]     XmlElem(null, "cite", fromStyle(attrs), TopScope, flattenAndDropLastEOL(elems) : _*) ::
[warn]     ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1116: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]     override def toHtml : NodeSeq = XmlElem(null, "pre", fromStyle(attrs.filter(validHtmlAttr("pre", _))), TopScope, flattenAndDropLastEOL(elems) : _*) ++ Text("\n")
[warn]                                     ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1122: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]     XmlElem(null, "a", fromStyle(allAttrs), TopScope, Text(alt) : _*)
[warn]     ^
[warn] /Users/richard/Developer/third-party/lift/modules/textile/src/main/scala/net/liftmodules/textile/TextileParser.scala:1131: method apply in object Elem is deprecated (since 2.10.0): Use the other apply method in this object
[warn]     override def toHtml : NodeSeq = XmlElem(null, "a", fromStyle(allAttrs), TopScope, Text(alt) : _*)
[warn]                                     ^
[warn] there was one feature warning; re-run with -feature for details
[warn] 45 warnings found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant