From f7c7632c715d73a6ca6ed242c1cb85b0ef68a05d Mon Sep 17 00:00:00 2001 From: maksim Date: Mon, 25 Nov 2024 11:07:13 +0100 Subject: [PATCH] refactor: rename forced to boosted use 'boosted' instead of 'forced' when we describe a mode when validators to exit are prioritized --- contracts/0.4.24/nos/NodeOperatorsRegistry.sol | 4 ++-- contracts/0.8.9/interfaces/IStakingModule.sol | 2 +- test/0.8.9/stakingRouter/stakingRouter.module-sync.test.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/contracts/0.4.24/nos/NodeOperatorsRegistry.sol b/contracts/0.4.24/nos/NodeOperatorsRegistry.sol index 1e5d30f3a..e7866e751 100644 --- a/contracts/0.4.24/nos/NodeOperatorsRegistry.sol +++ b/contracts/0.4.24/nos/NodeOperatorsRegistry.sol @@ -102,7 +102,7 @@ contract NodeOperatorsRegistry is AragonApp, Versioned { uint8 internal constant TOTAL_DEPOSITED_KEYS_COUNT_OFFSET = 3; // TargetValidatorsStats - /// @dev Target limit mode, allows limiting target active validators count for operator (0 = disabled, 1 = soft mode, 2 = forced mode) + /// @dev Target limit mode, allows limiting target active validators count for operator (0 = disabled, 1 = soft mode, 2 = boosted mode) uint8 internal constant TARGET_LIMIT_MODE_OFFSET = 0; /// @dev relative target active validators limit for operator, set by DAO /// @notice used to check how many keys should go to exit, 0 - means all deposited keys would be exited @@ -689,7 +689,7 @@ contract NodeOperatorsRegistry is AragonApp, Versioned { /// @notice Updates the limit of the validators that can be used for deposit by DAO /// @param _nodeOperatorId Id of the node operator - /// @param _targetLimitMode target limit mode (0 = disabled, 1 = soft mode, 2 = forced mode) + /// @param _targetLimitMode target limit mode (0 = disabled, 1 = soft mode, 2 = boosted mode) /// @param _targetLimit Target limit of the node operator function updateTargetValidatorsLimits(uint256 _nodeOperatorId, uint256 _targetLimitMode, uint256 _targetLimit) public { _onlyExistedNodeOperator(_nodeOperatorId); diff --git a/contracts/0.8.9/interfaces/IStakingModule.sol b/contracts/0.8.9/interfaces/IStakingModule.sol index 82d55cf05..bf7056ee3 100644 --- a/contracts/0.8.9/interfaces/IStakingModule.sol +++ b/contracts/0.8.9/interfaces/IStakingModule.sol @@ -23,7 +23,7 @@ interface IStakingModule { /// @notice Returns all-validators summary belonging to the node operator with the given id /// @param _nodeOperatorId id of the operator to return report for - /// @return targetLimitMode shows whether the current target limit applied to the node operator (0 = disabled, 1 = soft mode, 2 = forced mode) + /// @return targetLimitMode shows whether the current target limit applied to the node operator (0 = disabled, 1 = soft mode, 2 = boosted mode) /// @return targetValidatorsCount relative target active validators limit for operator /// @return stuckValidatorsCount number of validators with an expired request to exit time /// @return refundedValidatorsCount number of validators that can't be withdrawn, but deposit diff --git a/test/0.8.9/stakingRouter/stakingRouter.module-sync.test.ts b/test/0.8.9/stakingRouter/stakingRouter.module-sync.test.ts index b7bb09878..ead4a584b 100644 --- a/test/0.8.9/stakingRouter/stakingRouter.module-sync.test.ts +++ b/test/0.8.9/stakingRouter/stakingRouter.module-sync.test.ts @@ -340,7 +340,7 @@ describe("StakingRouter:module-sync", () => { context("updateTargetValidatorsLimits", () => { const NODE_OPERATOR_ID = 0n; - const TARGET_LIMIT_MODE = 1; // 1 - soft, i.e. on WQ request; 2 - forced + const TARGET_LIMIT_MODE = 1; // 1 - soft, i.e. on WQ request; 2 - boosted const TARGET_LIMIT = 100n; it("Reverts if the caller does not have the role", async () => {