-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept engines that require an interpreter #1023
Conversation
I don't think engine:
interpreter: java
interpreter_options:
- "-jar" The other commands = []
if cfg.interpreter:
commands.append(cfg.interpreter)
commands.extend(cfg.interpreter_options or [])
commands.append(engine_path)
if cfg.engine_options:
for k, v in cfg.engine_options.items():
commands.append(f"--{k}={v}" if v is not None else f"--{k}") I don't think there are any other cases besides interpreters for things going before the file containing the engine. |
Good. Now all that's needed is to document this in the wiki. I would also comment out |
For some reason the test fails, while I can run |
Type of pull request:
Description:
Allow users to provide arguements before and after the engine name (e.g. when a user is running a
jar
file as a chess engine).engine_options could be removed as
after_name_parameters
does the same thing but for a more general use case. On the other hand,engine_options
is easier to use and some people may depend on it, so if we remove it, we should probably deprecate it first.Related Issues:
closes #1022
Checklist:
Screenshots/logs (if applicable):