Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type checking of Python code #1701

Open
2 tasks
Changaco opened this issue Mar 11, 2020 · 1 comment
Open
2 tasks

Type checking of Python code #1701

Changaco opened this issue Mar 11, 2020 · 1 comment
Assignees
Labels
bug prevention early detection of bugs DevX making it easier to develop and maintain Liberapay

Comments

@Changaco
Copy link
Member

Changaco commented Mar 11, 2020

Looks like we didn't have an issue for this yet, so here's one.

Good type checking can eliminate entire classes of bugs, but neither the Python language nor Liberapay's code were designed to be type checked, so it's not easy.

  • Add a mypy check to Liberapay's tests.
  • Add type annotations to the code so that mypy will actually do something. This should be done gradually, not all at once. MonkeyType might help get this done faster.
@Changaco Changaco added good first issue suitable for new contributors DevX making it easier to develop and maintain Liberapay bug prevention early detection of bugs labels Mar 11, 2020
@Changaco
Copy link
Member Author

Relevant Aspen issues: AspenWeb/aspen.py#27 and AspenWeb/state_chain.py#27.

@Changaco Changaco self-assigned this Jul 17, 2023
@Changaco Changaco removed the good first issue suitable for new contributors label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug prevention early detection of bugs DevX making it easier to develop and maintain Liberapay
Development

No branches or pull requests

1 participant