Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add React 19 support #240

Open
ptmkenny opened this issue Aug 19, 2024 · 3 comments · Fixed by #253
Open

Add React 19 support #240

ptmkenny opened this issue Aug 19, 2024 · 3 comments · Fixed by #253

Comments

@ptmkenny
Copy link
Contributor

React 19 now has a release candidate, so it would be great to add support here.
@ptmkenny
Copy link
Contributor Author

ptmkenny commented Dec 5, 2024

React 19 has been released, so it would be great to add this now. I've been using rc1 for the past few weeks with react-h5-audio-player (via npm --force) in my app and have experienced no problems.

@ptmkenny ptmkenny mentioned this issue Dec 5, 2024
Merged
@lhz516
Copy link
Owner

lhz516 commented Dec 18, 2024

Sounds good.

@lhz516 lhz516 reopened this Dec 18, 2024
@lhz516
Copy link
Owner

lhz516 commented Dec 18, 2024

Published 3.10.0-rc.0

This is a pre-release because the testing library doesn't support React 19, and we still relied on React 18 for testing.
Trying to find a way to make tests pass with React 19.

Feel free to try it out and let me know if there is any issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to react 19 ptmkenny/react-h5-audio-player
2 participants
@ptmkenny @lhz516