-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider embedding icons #223
Comments
We need internet access to load the web page and play audio anyway. In the testing environment, I don't think it's necessary to show check if icons are displayed. If you want the icon to be embedded, you consider modifying the |
This is usually the case, but it's possible to use something like Ionic React to make a mobile app that loads local audio files without Internet access, and in such a case, the audio player will appear broken because no icons are displayed. I confirmed that the icons will be bundled if you download them and specify them using Perhaps this should be mentioned in the README? Something under "Advanced usage" like:
|
Sounds good. I can update when I get a chance |
At present, the icons in this audio player are loaded via a network request after the player has loaded. This can cause the player to fail in environments where access to the general Internet is restricted (for example, test servers). It also introduces network dependencies on third-party servers, which developers may want to avoid.
It seems this is because of the philosophy of the Iconify for React library:
However, react-h5-audio-play only specifies 10 icons, so I think it would be more reliable to bundle all 10 icons with the player.
The text was updated successfully, but these errors were encountered: