Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about the contents of Columns #94

Open
takutechnology opened this issue May 9, 2022 · 8 comments
Open

Questions about the contents of Columns #94

takutechnology opened this issue May 9, 2022 · 8 comments
Labels
documentation Improvements or additions to documentation

Comments

@takutechnology
Copy link

@lfoppiano Dear Luca-san.

I am writing a script to explain the columns in the figure below, but there are a few whose contents I don't understand.

スクリーンショット 2022-05-09 14 26 08

・Fabrication ・Substrate ・Link Type ・Type ・Status ・Flag

Please tell us what these are.

With Regards.
taku

@lfoppiano
Copy link
Owner

lfoppiano commented May 9, 2022

Some of the details can be found here: https://supermat.readthedocs.io/en/feature-material_parser/guidelines-material-parser.html

you can actually copy paste from there if you need.

The following: Link Type, Type, Status are internal values that should be ignored. As a matter of fact we should hide them from the interface.

Flag is indicating whether the record was "reported as incorrected".

Let me know if you have more questions.

@lfoppiano lfoppiano added the documentation Improvements or additions to documentation label May 9, 2022
@takutechnology
Copy link
Author

Thank you for your detailed explanation. I was able to understand it. I would like to write an explanation based on this.

Regards,
Taku

@takutechnology
Copy link
Author

@lfoppiano Dear Luca-san.

Terashima-san asked me to send the current status of the markdown to Luca-san, so I will do so.

スクリーンショット 2022-05-30 16 24 53

This is a table divided by the contents of Columns.

スクリーンショット 2022-05-30 16 26 37

I am then going to write a detailed description of each Columns in this format.
Do you have any opinions?

With Regards.
taku

@lfoppiano
Copy link
Owner

@taku641 is very good, could you please push it on github even if it's not completed?

@takutechnology
Copy link
Author

@lfoppiano I just pushed !

@lfoppiano
Copy link
Owner

lfoppiano commented May 31, 2022

@taku641 where? I don't see any new commit or push. Ideally could you please use the guidelinesmodif guidelines branch?

@lfoppiano
Copy link
Owner

Check mattermost 😉

@lfoppiano
Copy link
Owner

lfoppiano commented May 31, 2022

I noticed that in the table, the "unit-cell" should be moved to "items related to composition"

See example:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants