-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rules to be added #117
Comments
OK for all. 1 and 2 should be removed with error type "Composition resolution" |
By the way, @kensei-te these are all going into the guidelines, isn't it? |
Yes, if other people agree with this rule. |
My opinion is that, for 3:, this should be linking error in theory (if we could link "high pressure" to Tcvalue). And, since pressure value is not extracted, it is virtually extracted as if it is the Tcvalue of ambient pressure. In this sense, it is "wrong". Another possible opinion is that, if we think that such unspecified expression should not be extracted, it could be "Invalid", but I have no idea what error-type can correspond to this. Is an extraction of "high pressure" as pressure possible in the current system? |
The expression "high pressure" is in the training data, so I'm assuming it has to be extracted.
That's my opinion |
In the current system, how we do this? |
There is a remove button (the bin near the "edit"): which now opens the same dialog box as the "edit" button. Indeed, we need to gray out the whole form (just opened #124). |
|
I mean, those should be "remove"d by curator, with error-type "values resolution". strictly speaking, it is not an error, system is not wrong, but for convention. |
Yes, I agree with you. We can add "Values resolution" within the error types |
ok. Until this error type is added, what should we do for curation of this kind data? |
Sure! |
Here, for "Values resolution", I want to add one more. Since data in tables and figures are out of scope, curator should not try hard to fill to complete variables in formula if values for variables are available only at tables or figures, not the sentence itself. Therefore, such imcomplete formula (material name) should be assigned to "Values resolution" error as well. |
In the guideline, we need to mention what we should do when there is an unresolved formula such as,
"(Ca, Pr)FeAs2", "Ca1-xPrxFeAs2" without given x explicitly.
I think these should be removed.
For the formula, we should mention that abbreviation is not accepted, such as,
"(Ca,Pr)112"
If curator get to know the complete formula from the context (sentences nearby), it has to be filled. Otherwise, those has to be removed.
Same rule can be applied to pressure value as well. Sometimes we see such an expression that,
"Tc^{max} of 10 K has been achieved under high pressure", where the exact value of pressure is unwritten.
We should remove such entity.
We should mention that we do not store the rate, such as,
"Tc decreases by pressure with dTc/dP ~ 3 K/GPa"
We also do not try to calculate Tc under pressure based on above expression.
Any opinion?
The text was updated successfully, but these errors were encountered: