Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation of currencies #59

Open
everzeni opened this issue Feb 27, 2018 · 4 comments
Open

Annotation of currencies #59

everzeni opened this issue Feb 27, 2018 · 4 comments
Labels

Comments

@everzeni
Copy link
Collaborator

Even in scientific papers, we may stumble upon expressions of amounts of money (150$, 3€).

Do we annotate $, , etc?

@lfoppiano
Copy link
Owner

Honestly not a clue... we could annotate them with type CURRENCY perhaps and have the automatic transformation based on the exchange rate, but I'm not sure we have done it before.

@kermitt2 what do you think?

@kermitt2
Copy link
Collaborator

yes it makes definitively sense to annotate them with the currency as unit and using a type CURRENCY. So far I didn't see such expression of money in the first batch of training data.

@everzeni everzeni added task and removed question labels Mar 1, 2018
@everzeni
Copy link
Collaborator Author

everzeni commented Mar 5, 2018

here is an example from halshs-01279855.training.tei.xml:

the French professional football league broadcasting rights over <measure type="value">
<num>one</num></measure> season (<measure type="value"><measure type="CURRENCY" 
unit="">€</measure> <num>668 million</num></measure>)

@lfoppiano
Copy link
Owner

unit="€" I would write something like unit="euro" instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants